This repository was archived by the owner on Oct 18, 2018. It is now read-only.
generate manifests used for Mozilla build system with one entry per line#185
Closed
jhford wants to merge 4 commits intomozilla-services:developfrom
Closed
generate manifests used for Mozilla build system with one entry per line#185jhford wants to merge 4 commits intomozilla-services:developfrom
jhford wants to merge 4 commits intomozilla-services:developfrom
Conversation
Instead of generating manifest files, lets instead generate a makefile that has the variables needed.
Contributor
Author
|
The first two commits in the pull request would require landing https://bug752873.bugzilla.mozilla.org/attachment.cgi?id=622419 and the makefile would require https://bug752873.bugzilla.mozilla.org/attachment.cgi?id=622424 https://tbpl.mozilla.org/?tree=Try&rev=d70761ec02ed . The logs for a green build with the test push are here http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jford@mozilla.com-d70761ec02ed/try-android/try-android-bm14-try1-build1657.txt.gz |
Contributor
|
Manually merged with fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of mozilla bug 752873, instead of having the tr overhead on every android build, move the work of generating one file per manifest file line to the android-sync code drop script. Another approach is to generate a makefile that has the date from the manifests. This avoids the shell call overhead entirely.