Add statsd timer collection for http, get reputation, and redis commands #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ameihm0912
approved these changes
Feb 11, 2019
| AWS bool | ||
| } | ||
| VersionResponse string | ||
| Statsd struct { |
Contributor
Author
There was a problem hiding this comment.
No, but it does look weird. It's just being aligned with the VersionResponse above it.
| WriteTimeout: time.Millisecond * time.Duration(cfg.Redis.WriteTimeout), | ||
| DialTimeout: time.Millisecond * time.Duration(cfg.Redis.DialTimeout), | ||
| }) | ||
| ret.master.WrapProcess(instrumentRedisCmd) |
There was a problem hiding this comment.
Is the performance impact of wrapping every redis command with a statsd call fairly negligible?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds optional statsd metric collection, with a generic http timer, a get reputation timer, and a timer for all redis commands.