chore: Fix e2e tests by using new MARS alt texts as the accessible-first selectors#76
Merged
mashalifshin merged 1 commit intomainfrom Jul 3, 2025
Merged
Conversation
mashalifshin
changed the title
mashalifshin
changed the title
justindarc
approved these changes
Jul 3, 2025
Almaju
pushed a commit
to Almaju/majc
that referenced
this pull request
Sep 22, 2025
…rst selectors (mozilla-services#76) Update alt text selectors to use new MARS alt texts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
Recently, MARS changed how they contruct alt text for the mock placements. We use those alt texts as an accessible-first selector in our end-to-end cross browser tests, so this change in MARS broke our tests on
main. We can't merge PRs until this is resolved.Proposed Changes
Update to the new style of alt text to go green on
mainagain.In the future, we may consider setting aside some special test placements just for our examples and for these e2e tests, not just use the mock pocket placements, but for now this is a good fix.
Verification Steps
Seeing that the e2e tests pass in CI is sufficient to verify this change.