Minor coding standards related stuff #485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reggino
commented
Feb 22, 2017
Reggino
commented
- Added .editorconfig for EditorConfig support
- Add yarn.lock to .gitignore since it's widely used
- Minor coding standards issue
- Add yarn.lock to .gitignore since it's widely used - Minor coding standards issue
n1k0
approved these changes
Feb 23, 2017
Collaborator
n1k0
left a comment
n1k0
left a comment
There was a problem hiding this comment.
LGTM with nits addressed. Thanks!
.editorconfig
Outdated
| @@ -0,0 +1,2 @@ | |||
| indent_style = space | |||
| indent_size = 2 No newline at end of file | |||
Collaborator
There was a problem hiding this comment.
Nit: Please ass a trailing CR to avoid diff issues.
.gitignore
Outdated
| dist | ||
| lib | ||
|
|
||
| yarn.lock |
Collaborator
There was a problem hiding this comment.
Nit: Please ass a trailing CR to avoid diff issues.
Collaborator
|
Thank you 👍 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.