Skip to content

Comments

bug-1954596: update stackwalker to v0.25.0#6947

Merged
willkg merged 1 commit intomainfrom
willkg-bug-1954596-softerror
Mar 22, 2025
Merged

bug-1954596: update stackwalker to v0.25.0#6947
willkg merged 1 commit intomainfrom
willkg-bug-1954596-softerror

Conversation

@willkg
Copy link
Collaborator

@willkg willkg commented Mar 22, 2025

This updates the stackwalker to v0.25.0. One thing this picks up is a new field in the stackwalker output: soft_errors.

However, the value for that field is documented as "object" and we don't know what that is so we can't put it in the schema. If they want that field to be public or if they want us to do something with it in Crash Stats, they'll have to flesh out the structure of the object.

https://github.com/rust-minidump/rust-minidump/blob/4bc0e1bb3a19f22d5b7c4057112197ac5f6ea2d9/minidump-processor/json-schema.md#L692-L693

To test:

  1. build socorro
  2. process some crash reports and df1ce584-5ad2-4b35-9c0f-a00ed0250321
  3. verify that the stackwalker doesn't crash
  4. log into http://localhost:8000 with an account with protected data access
  5. view df1ce584-5ad2-4b35-9c0f-a00ed0250321 and look at the Raw Data and Minidumps tab and search for "soft_errors"--it should be an empty list:
    soft_errors: [],
    

This updates the stackwalker to v0.25.0. One thing this picks up is a
new field in the stackwalker output: soft_errors.

However, the value for that field is documented as "object" and we don't
know what that is so we can't put it in the schema. If they want that
field to be public or if they want us to do something with it in Crash
Stats, they'll have to flesh out the structure of the object.
@willkg willkg requested a review from a team as a code owner March 22, 2025 00:46
@willkg willkg added this pull request to the merge queue Mar 22, 2025
Merged via the queue into main with commit 8c18426 Mar 22, 2025
1 check passed
@willkg willkg deleted the willkg-bug-1954596-softerror branch March 22, 2025 00:59
@willkg
Copy link
Collaborator Author

willkg commented Mar 22, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants