bug-1954596: update stackwalker to v0.25.0#6947
Merged
Conversation
This updates the stackwalker to v0.25.0. One thing this picks up is a new field in the stackwalker output: soft_errors. However, the value for that field is documented as "object" and we don't know what that is so we can't put it in the schema. If they want that field to be public or if they want us to do something with it in Crash Stats, they'll have to flesh out the structure of the object.
relud
approved these changes
Mar 22, 2025
Collaborator
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the stackwalker to v0.25.0. One thing this picks up is a new field in the stackwalker output: soft_errors.
However, the value for that field is documented as "object" and we don't know what that is so we can't put it in the schema. If they want that field to be public or if they want us to do something with it in Crash Stats, they'll have to flesh out the structure of the object.
https://github.com/rust-minidump/rust-minidump/blob/4bc0e1bb3a19f22d5b7c4057112197ac5f6ea2d9/minidump-processor/json-schema.md#L692-L693
To test:
http://localhost:8000with an account with protected data access