-
Notifications
You must be signed in to change notification settings - Fork 73
chore: migrate tokenserver tests to pytest with junit output #1657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢. Don't forget to squash before merging.
What is the ticket number for the remaining work for e2e tests? I don't see it in the epic atm.
| cargo llvm-cov report --summary-only --json --output-path ${UNIT_COVERAGE_JSON} | ||
| cargo llvm-cov report --summary-only --json --output-path ${UNIT_COVERAGE_JSON} | ||
|
|
||
| .ONESHELL: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: more of a note to @Trinaa and @jrconlin as we have this in autopush too -- it seems .ONESHELL is a Makefile wide special target that only needs to be set once, "If the .ONESHELL special target appears anywhere in the makefile then all recipe lines for each target.."
|
@nshirley and don't forget to add a "chore:" prefix to the commit when you squash |
Description
Describe these changes.
The original ticket was scoped to move all python tests (tokenserver, mysqle2e and spannere2e) to utilize pytest, but for the sake of speed the latter two will be tackled in another ticket.
Interestingly, by using pytest it can discover the existing
unittesttests and run them without extra work at this time, and in doing so, it's also running more tests that were not being run before! Here are the tests that additionally run:Should we keep these tests in? Do they need to run?
Testing
How should reviewers test?
Issue(s)
Closes SYNC-4516.