Skip to content

fix: don't call begin twice for mysql's delete_all#673

Merged
jrconlin merged 2 commits intomasterfrom
fix/639
Jun 12, 2020
Merged

fix: don't call begin twice for mysql's delete_all#673
jrconlin merged 2 commits intomasterfrom
fix/639

Conversation

@pjenvey
Copy link
Member

@pjenvey pjenvey commented Jun 12, 2020

Description

and adjust ACTIX_THREADPOOL per the database_pool_max_size on mysql

Testing

tests pass under mysql

Issue(s)

Closes #639
Closes #441

and adjust ACTIX_THREADPOOL per the database_pool_max_size on mysql

Closes #639
Closes #441
@pjenvey pjenvey requested a review from a team June 12, 2020 22:28
Copy link
Member

@jrconlin jrconlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I keep thinking there was a way for rust to get the cpu count natively, but perhaps i'm confusing it with https://github.com/seanmonstar/num_cpus

@jrconlin jrconlin merged commit c93db75 into master Jun 12, 2020
@jrconlin jrconlin deleted the fix/639 branch July 30, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants