Skip to content

feat: More purge_ttl features#776

Merged
AzureMarker merged 4 commits intomasterfrom
feat/purge_ttl-more-features
Aug 11, 2020
Merged

feat: More purge_ttl features#776
AzureMarker merged 4 commits intomasterfrom
feat/purge_ttl-more-features

Conversation

@AzureMarker
Copy link
Contributor

Description

  • Add --mode/PURGE_MODE to choose if batches, bsos, or both tables should be purged.
  • Add --expiry_mode/PURGE_EXPIRY_MODE to choose if the expiry should be compared against midnight or now.
  • Support serially deleting UID prefixes by regex, with --uid_prefixes/PURGE_UID_PREFIXES.
    • This is a list of regex, ex. [^[a-h],^[i-p]].
    • Each entry is a separate purge run.
    • This replaces --uid_starts.
  • Change --collection_ids/COLLECTION_IDS from a JSON list to an "args" list (like --uid_prefixes).

Testing

Run against dev

Issue(s)

Closes #735
Closes #743

Also changes the collection IDs option from a JSON list to an args list
(i.e. [item1,item2,item3]).
@AzureMarker AzureMarker merged commit 59aa28a into master Aug 11, 2020
@AzureMarker AzureMarker deleted the feat/purge_ttl-more-features branch August 11, 2020 19:05
@jrconlin jrconlin mentioned this pull request Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[purge ttl] add more feature flags to control what gets purged [purge-ttl] Consider using REGEXP_CONTAINS() for fxa_uid group matching

2 participants