fix: Avoid implicit transactions in DbTransactionPool#777
Merged
AzureMarker merged 4 commits intomasterfrom Aug 13, 2020
Merged
fix: Avoid implicit transactions in DbTransactionPool#777AzureMarker merged 4 commits intomasterfrom
AzureMarker merged 4 commits intomasterfrom
Conversation
pjenvey
requested changes
Aug 11, 2020
Also do some refactoring to simplify the code.
Now that it's handled in TransactionDbPool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Always create a transaction when using
DbTransactionPool. This avoids implicit transactions.Testing
Not sure how the issue is/was detected, so not sure on testing.
Issue(s)
Potential fix for #768