Skip to content

Conversation

@grahamalama
Copy link
Contributor

No description provided.

@grahamalama grahamalama requested a review from a team as a code owner May 13, 2024 15:50
Copy link
Contributor

@leplatrem leplatrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May require a INSTALL_DEV target in our makefile for dev operations like lint, test?

@grahamalama
Copy link
Contributor Author

May require a INSTALL_DEV target in our makefile for dev operations like lint, test?

It seems like doing poetry install will install the dev dependencies by default, since that group isn't marked as optional.

So in the future, I would like to make that group optional then modify the Makefile as you suggested

@grahamalama grahamalama merged commit c3966c6 into main May 13, 2024
@grahamalama grahamalama deleted the move-dev-deps branch May 13, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants