This repository was archived by the owner on Jun 19, 2025. It is now read-only.
Added optimizer for lm_alpha + lm_beta#2783
Merged
kdavis-mozilla merged 2 commits intomasterfrom Mar 17, 2020
Merged
Conversation
No Taskcluster jobs started for this pull requestThe `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request. |
4393aea to
d13f311
Compare
0016aa2 to
15a6556
Compare
rhamnett
suggested changes
Feb 25, 2020
Contributor
rhamnett
left a comment
There was a problem hiding this comment.
Fix for optimizer.py to run correctly
cf5bb9b to
a3055ea
Compare
Contributor
|
Good work :) |
a3055ea to
561131a
Compare
Contributor
|
This is awesome, thanks! I was just going to go about implementing my own :) |
Contributor
Author
|
Thanks, and you don't need to re-compile. |
reuben
approved these changes
Mar 17, 2020
Contributor
reuben
left a comment
There was a problem hiding this comment.
Awesome \o/
Just one comment, maybe rename this file to something less generic?
Contributor
Author
|
@reuben Do you have any ideas? Maybe |
Contributor
|
Yeah I like |
This was referenced Mar 17, 2020
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.