This repository was archived by the owner on Jun 19, 2025. It is now read-only.
batch transcribe dir (recursively) with transcribe.py#2879
Merged
tilmankamp merged 2 commits intomozilla:masterfrom Apr 3, 2020
Merged
batch transcribe dir (recursively) with transcribe.py#2879tilmankamp merged 2 commits intomozilla:masterfrom
tilmankamp merged 2 commits intomozilla:masterfrom
Conversation
tilmankamp
suggested changes
Apr 2, 2020
Contributor
tilmankamp
left a comment
tilmankamp
left a comment
There was a problem hiding this comment.
Looking good.
Just a nit on some unnecessarily complicated code.
transcribe.py
Outdated
| dst_paths = [ path.replace('.wav','.tlog') for path in paths ] | ||
| elif kind == 'catalog': | ||
| # the user pointed to a catalog dir from DSAlign | ||
| src_paths,dst_paths = zip(*paths) |
Contributor
There was a problem hiding this comment.
Why so complicated? This if block and the kind parameter are not required if all the case-specific preparations would just be done in the corresponding cases in main - just before calling transcribe_many.
Contributor
Author
There was a problem hiding this comment.
un-complicat-ified the function:)
tilmankamp
approved these changes
Apr 3, 2020
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.