Stop scraping www.mozilla.org for bouncer download links #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead query the bouncer URLs directly (bedrock changes mean the previous check no longer finds the links). Fixes mozilla#247
Contributor
Author
|
@mozbhearsum can you review this? |
Contributor
|
I'll have a look today. |
bhearsum
reviewed
Oct 25, 2019
Contributor
bhearsum
left a comment
bhearsum
left a comment
There was a problem hiding this comment.
Looks good overhaul, just one main suggestion below.
bhearsum
approved these changes
Nov 5, 2019
Contributor
|
This should be in production now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead query the bouncer URLs directly (bedrock changes mean the
previous check no longer finds the links).
Fixes #247