Skip to content
This repository was archived by the owner on Feb 29, 2020. It is now read-only.

Fix(pingcentre): Collect region and profile creation date#3875

Merged
ncloudioj merged 1 commit intomozilla:masterfrom
ncloudioj:gh-pingcentre-117
Nov 22, 2017
Merged

Fix(pingcentre): Collect region and profile creation date#3875
ncloudioj merged 1 commit intomozilla:masterfrom
ncloudioj:gh-pingcentre-117

Conversation

@ncloudioj
Copy link
Copy Markdown
Member

This closes ping-centre #117 and #111

Copy link
Copy Markdown
Contributor

@emtwo emtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ncloudioj

@ncloudioj ncloudioj merged commit 62279f9 into mozilla:master Nov 22, 2017
@ncloudioj ncloudioj deleted the gh-pingcentre-117 branch November 22, 2017 18:53
@ncloudioj ncloudioj requested a review from fmarier November 22, 2017 19:18
@ncloudioj
Copy link
Copy Markdown
Member Author

@fmarier r? data review, plz?

The UT is also looking to add the "region" (same as we're doing here) in the telemetry, see more details here https://bugzilla.mozilla.org/show_bug.cgi?id=1419788

@as-pine-proxy
Copy link
Copy Markdown
Collaborator

@fmarier
Copy link
Copy Markdown

fmarier commented Nov 22, 2017

Is there documentation about this to review?

@ncloudioj
Copy link
Copy Markdown
Member Author

@fmarier Since those are not AS specific metrics, I didn't include them in the data_events.md and data_dictionary.md. Let me file a followup PR to add them in, hopefully that makes it easier to review.

@fmarier fmarier removed their request for review November 23, 2017 20:56
@fmarier fmarier removed their assignment Nov 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants