This repository was archived by the owner on Feb 29, 2020. It is now read-only.
fix(prerender): Check top before loading more scripts#4128
Merged
Mardak merged 1 commit intomozilla:masterfrom May 1, 2018
Merged
fix(prerender): Check top before loading more scripts#4128Mardak merged 1 commit intomozilla:masterfrom
Mardak merged 1 commit intomozilla:masterfrom
Conversation
k88hudson
approved these changes
May 1, 2018
Contributor
k88hudson
left a comment
k88hudson
left a comment
There was a problem hiding this comment.
I tested this on prerendered/non-prerendered pages and I don't see a difference – can you maybe just clarify what the reasoning for this / when this condition actually occurs?
Contributor
|
Ok, this works as expected 👍 |
Mardak
added a commit
that referenced
this pull request
May 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r?@k88hudson Just short circuit the rest of the top level script