This repository was archived by the owner on Feb 26, 2022. It is now read-only.
Bug 632572 - CommonJS test adapter#93
Merged
10 commits merged intoFeb 16, 2011
Merged
Conversation
Contributor
Author
There was a problem hiding this comment.
You're right I had to return assertionError
Contributor
Author
There was a problem hiding this comment.
Thanks, I've fixed that!
Contributor
Author
|
As I suggested on the IRC I have modified this pull request to point to a different bug. There for scope of is changed and it only aims to get CommonJS test adapter. |
Contributor
Author
|
Also I think that code follows all the conventions, if you see where it's not can you please comment inline or post a line number ? |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.