Skip to content

Move learn more link in PremissionsCard #13870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2025
Merged

Move learn more link in PremissionsCard #13870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 14 additions & 17 deletions src/amo/components/PermissionsCard/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,25 +77,9 @@ export class PermissionsCardBase extends React.Component<InternalProps> {
? i18n.gettext('Data collection:')
: i18n.gettext('Required data collection, according to the developer:');

const header = (
<div className="PermissionsCard-header">
{i18n.gettext('Permissions and data')}
<Link
className="PermissionsCard-learn-more"
href="https://support.mozilla.org/kb/permission-request-messages-firefox-extensions"
target="_blank"
externalDark
prependClientApp={false}
prependLang={false}
>
{i18n.gettext('Learn more')}
</Link>
</div>
);

return (
<ShowMoreCard
header={header}
header={i18n.gettext('Permissions and data')}
contentId={version.id}
className="PermissionsCard"
id="AddonDescription-permissions-card"
Expand Down Expand Up @@ -143,6 +127,19 @@ export class PermissionsCardBase extends React.Component<InternalProps> {
</ul>
</>
) : null}

<div className="PermissionsCard-footer">
<Link
className="PermissionsCard-learn-more"
href="https://support.mozilla.org/kb/permission-request-messages-firefox-extensions"
target="_blank"
externalDark
prependClientApp={false}
prependLang={false}
>
{i18n.gettext('Learn more')}
</Link>
</div>
</ShowMoreCard>
);
}
Expand Down
4 changes: 4 additions & 0 deletions src/amo/components/PermissionsCard/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,7 @@
padding-left: 8px;
}
}

.PermissionsCard-footer {
margin: 24px auto 0;
}
3 changes: 2 additions & 1 deletion src/amo/pages/Addon/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@
padding: 0;
}

* > .Card-contents {
* > .Card-contents,
*.ShowMoreCard--expanded > .Card-contents {
border-radius: 0;
margin: 0;
padding: 0;
Expand Down