Have feature themes collection membership be treated as recommended

[eviljeff]

(At least at first) themes aren't going to go through the same process as extensions to get recommended - they don't have code so don't need a code review so we'll reuse the existing way featured themes are selected (by membership of special collection)

[ioanarusiczki]

@eviljeff - I tested on AMO dev - FF66(Win10) and here are my results with the associated questions:

so we'll reuse the existing way featured themes are selected (by membership of special collection)

• as far as I know the featured theme collection can be edited (if the user has rights to do so) from admin tools or frontend.
  When a theme is added to this collection the "featured" label automatically is displayed. - will the "recommended" badge show instead of "featured" once Display recommended bage for all add-on types #13197 lands?

• right now the featured theme collection is displayed on the homepage and once the See more blue link is clicked there's also the "Recommended add-ons only" flag available.
  The number of themes is 9 with ?featured=true&type=statictheme as search parameters.
  Adding recommended ,the number of themes is 9 with ?featured=true&recommended=true&type=statictheme.
  I receive the same results from the API "count": 9 for https://addons-dev.allizom.org/api/v5/addons/search/?featured=true&type=statictheme
  and "count": 9, for making a request with the recommended parameter https://addons-dev.allizom.org/api/v5/addons/search/?recommended=true&featured=true&type=statictheme

Which means that once the theme is added in the featured collection it's also considered as being recommended and nothing else needs to be done such as adding the recommendable flag from Discovery items and for it's last version (which can be done but if the theme is not part of the featured collection it won't be a real use case). Did I get it right?
Also, I can't tell if that Recommended flag is going away from here, that's if the featured is entirely removed and replaced with recommended.

• a while ago I filed two issues about the featured theme collection and one I transferred it from the frontend repo to server today Problems adding themes for the featured theme collections from django pages #6312 and Adding themes in the featured themes collection doesn't work #6692.

[ioanarusiczki]

#13197 has landed so
Static themes which are added to the Featured Themes collection will automatically become Recommended (is_recommended": true) and they'll display the badge.