Skip to content

themes in the featured collection should be seen as recommended too#11435

Merged
eviljeff merged 1 commit into
mozilla:masterfrom
eviljeff:11429-themes-collection-is-recommended
May 20, 2019
Merged

themes in the featured collection should be seen as recommended too#11435
eviljeff merged 1 commit into
mozilla:masterfrom
eviljeff:11429-themes-collection-is-recommended

Conversation

@eviljeff

Copy link
Copy Markdown
Member

@eviljeff eviljeff force-pushed the 11429-themes-collection-is-recommended branch from f8ff38f to d114094 Compare May 15, 2019 12:03
@eviljeff eviljeff requested a review from diox May 15, 2019 12:04
@diox

diox commented May 15, 2019

Copy link
Copy Markdown
Member

Why can't they be added to the disco items like normal ? If we do this I'm worried there will be a disconnect between AMO and Firefox: they are not going to get the signature bits, so they aren't going to be shown as recommended in Firefox itself.

@eviljeff

Copy link
Copy Markdown
Member Author

@diox a question to bring up with Jorge (in the issue or PRD) - he wanted recommended themes to still be a collection.

@jvillalobos

Copy link
Copy Markdown
Contributor

The need to have the collection is that the featured/recommended themes list is maintained by relatively low-tech community members. Also, since that list will be managed differently and will be cycled regularly, it doesn't make sense to add any of the review / signing bits to it. It will be inconsistent either way. Not showing the badge for installed themes in about:addons is okay.

@eviljeff eviljeff merged commit ec01590 into mozilla:master May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Have feature themes collection membership be treated as recommended

3 participants