Skip to content

12842 drop is source public property #13773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

12842 drop is source public property #13773

wants to merge 3 commits into from

Conversation

@wanjing-h
Copy link

@junngo
Copy link
Contributor

junngo commented Mar 19, 2020

There is a lint error.
Please check the error using the following command:
docker-compose exec web make lint-codestyle

eviljeff
eviljeff requested changes Mar 19, 2020
View reviewed changes
Copy link
Member

@eviljeff eviljeff left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid this is wrong. The issue is to "Drop is_source_public property from Addon model" - you're making changes to the API serializer (which was already changed in #12514 leaving just a shim for backwards compatibility)
-- edit, the property is called view_source on Addon

@eviljeff
Copy link
Member

closing this. This isn't the correct solution - it's the Addon.view_source property that needs removing and all references to it.

@eviljeff eviljeff closed this Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eviljeff eviljeff eviljeff requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Drop view_source property from Addon model

4 participants

@wanjing-h @junngo @eviljeff @AlanXu12