Expose data collection permissions in API #23581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eviljeff
approved these changes
Jun 16, 2025
| data_collection_permissions = serializers.ListField(child=serializers.CharField()) | ||
| optional_data_collection_permissions = serializers.ListField( | ||
| child=serializers.CharField() | ||
| ) |
There was a problem hiding this comment.
I know it doesn't matter a great deal... But these extra properties should be behind an API gate
There was a problem hiding this comment.
Should they ? It's just new properties so I don't really care. We didn't bother when we added host_permissions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#15620
Testing
http://olympia.test/api/v5/addons/addon/<pk_or_slug_or_guid>/) and search API (http://olympia.test/api/v5/addons/search/?guid=<guid>) and checkdata_collection_permissionsandoptional_data_collection_permissionsare there and correctBonus: