[Task]: Add special handling for content reviews performed via Cinder

[eviljeff]

Description

When a decision is made by a moderator in Cinder on an add-on content review we need to record it as a specific content review.

(This issue may be subsumed by other issues)

Acceptance Criteria

• item 1

┆Issue is synchronized with this Jira Task

[diox]

We might also need specific actions for the content review queue, and their own implementation, if we're not re-using things we already have like force disable/force enable.

[eviljeff]

A prerequisite for this was being able to handle the incoming webhook. It turned out to be a non-trivial change itself so I've spun it out to #16155

[eviljeff]

So, it turns out identifying content reviews from the content review queue in Cinder is the easy case - we record the source queue for every CinderDecision (as from_job_queue). The problems are around consistency - if we want content review decisions not carried out from the content review queue in Cinder to also be counted as content reviews too. The four scenarios I can think of (and there may be others):

• content review carried out in Cinder, in the content review queue, on a job we created via an event
• that job was forwarded to the T&S escalations queue, who carried out the review
• that job was forwarded to the AMO reviewer team (possibly via T&S escalations!), who carried out the review
• the content review tool in the AMO reviewer tools was used to carry out a content review (possibly independent of any forwarding)

For only the first scenario ContentDecision.from_job_queue would be 'amo-dev-listing-content', so that itself is not enough (unless we change it under some circumstances). We could also store that the decision was from a content review in the decision metadata json blob (which is something we do for AMO reviewer tools content reviews... but only when the enable-content-rejection waffle switch is off and using version rejection)

[eviljeff]

Further thoughts on this : we need to be clear what we're defining as a "content review".

• Is it a review from either the listing content queue in Cinder or the reviewer tools content queue?
• Is it a decision that has a content review linked action (Approve, or RejectListingContent)?
• Or is it a review that originated - was triggered - by the submission or name/summary name?

In most cases those are going to be the same thing, but the edge cases are when a job is moved/forwarded, and other policies with other actions are used (e.g. it's forwarded and an AMO reviewers decides to force disable the add-on); or if the content review policies are available for selection from other queues (e.g. the Approve policy is also available in the extension Listing queue).