[Bug]: error when filtering by promoted group or by approval in admin discoveryaddon

[ioanarusiczki]

Is there an existing issue for this?

• I have searched the existing issues

What happened?

Go to https://addons-internal.dev.mozaws.net/en-US/admin/models/discovery/discoveryaddon/ and filter by promoted group or by approval - pick any option from the list

What did you expect to happen?

I get a server error. Sounds like a regression because I tried on stage but I could not reproduce it.

┆Issue is synchronized with this Jira Task

[eviljeff]

Probably https://mozilla.sentry.io/issues/7360187032/?project=6224627 - I can't immediately tell whether it's django5.2 related, but it is in our code that intersects with django admin, so quite possible.

[diox]

I can reproduce locally, and it goes away with Django 4.2.

The filter we're doing is a __in=<string> which is suspicious...

[eviljeff]

From the traceback, ','.join(selected_values),is failing - selected_values is seemingly a list of strings in django42, but [ ['Recommended"], "Recommended" ] in django52

[diox]

Yeah, we have no tests around that filtering code at all, and the underlying code in Django has changed. I'll fix and add tests.

[ioanarusiczki]

It's working for me.