Support RTAMO for all badged add-ons

[jvillalobos]

RTAMO now works with add-ons that have a DiscoveryItem, but we want it to work will all badged add-ons (Recommended, By Firefox, Verified, Sponsored). RTAMO is being brought back to Firefox soon. Related bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1670908.

[AlexandraMoga]

I've tried to verify the RTAMO flow with data from -dev and stage but as far as we (QA) and the developer in charge with the feature are aware, there is no method (like a pref change) that would allow RTAMO to work with data from -dev or stage.
Because of this limitation, I will be able to verify this issue only after the push on Thursday with data from prod.

[diox]

In the meantime, you can test that the API returns expected info by querying the search endpoint with a guid parameter set to rta: + the guid of the add-on in base64 format. We should return:

• A 400 error if the feature is disabled (it's behind a waffle switch)
• A 400 error if the base64 part of the parameter can't be decoded (invalid base64)
• A 200 response with no results if the guid doesn't match a badged add-on
• A 200 response with a single result corresponding to the guid if the corresponding add-on is badged

For instance, on dev:

• https://addons-dev.allizom.org/api/v4/addons/search/?guid=rta:blah should return a 400 error
• https://addons-dev.allizom.org/api/v4/addons/search/?guid=rta:Ym9yZGVyaWZ5QGV4YW1wbGUuY29t should return a 200 with no results (not a badged add-on)
• https://addons-dev.allizom.org/api/v4/addons/search/?guid=rta:YWRkb25AZGFya3JlYWRlci5vcmc= should return a 200 with the add-on info (badged add-on)

Note that there is a slight limitation: it will consider any badged promotion for any app (as long as it's been approved and it's for the latest public version), so for instance https://addons-dev.allizom.org/api/v4/addons/search/?guid=rta:YWxsUGVybWlzc2lvbnMxQG1vemlsbGEuY29t works, because even though the corresponding add-on is not currently promoted on desktop, it is for Android.

[diox]

Also, Firefox's Return to AMO feature should use extensions.getAddons.get.url preference to get information about the add-on, so you should be able to change that pref to point to dev and have it working that way. Obviously it's a little tricky to do as you need to customize the preferences before the browser starts for the first time, or find a way to re-trigger Return to AMO with an existing browser.

[AlexandraMoga]

Thanks Mat for the good instructions!

This issue is verified fixed on -dev:

API results:

• Recommended - https://addons-dev.allizom.org/api/v4/addons/search/?guid=rta:ezY0ZDIzZmNjLTMxZmYtNDdjOS04NzVlLWQ5MTI3YWQzMzcyM30= => 200 with add-on details returned
• Sponsored - https://addons-dev.allizom.org/api/v4/addons/search/?guid=rta:ezFkZjk3NjA1LTY4NTYtNGVkZS1hMzBjLWNjNmUzMmQ2YmI5Yn0= => 200 with add-on details returned
• Verified - https://addons-dev.allizom.org/api/v4/addons/search/?guid=rta:Ymxvb2R5dmlraW5nc3NAZmZzLWRldg== => 200 with add-on details returned
• By Firefox - https://addons-dev.allizom.org/api/v4/addons/search/?guid=rta:ezJlM2E2OGUzLTlhZDktNDY1My1iYzRjLTAzYmY4ODc3YWUzYX0= => 200 with add-on details returned
• Recommended theme (set as DiscoveryItem) - https://addons-dev.allizom.org/api/v4/addons/search/?guid=rta:ezkxN2NiOGM4LTlmYjctNDc1Ni1iNzQ4LWFiNWFlOTE4MDRkNH0= => 200 with add-on details returned
• Recommended theme (from featured-personas) https://addons-dev.allizom.org/api/v4/addons/search/?guid=rta:e2Y5YjljZGQzLTkxYWUtNDc2ZS05YzIxLWQ1ZWNmY2U5ODg5Zn0= => 200 with add-on details returned
• Not promoted - https://addons-dev.allizom.org/api/v4/addons/search/?guid=rta:e2QzOGFmZjllLTQ4MmEtNGRhNy05ZTU3LTBkZTAwYzE0YjlhN30= => 200 with no results
• Invalid guid encoding - https://addons-dev.allizom.org/api/v4/addons/search/?guid=rta:e2QzOGZjllLTQ4MmEtNGRhNy05ZTU3LTBkZTAwYz => 400 - "Invalid Return To AMO guid (not in base64url format?)"
• with the return-to-amo waffle switch disabled => 400 - "Return To AMO is currently disabled"

about:welcome with extensions.getAddons.get.url pointed to -dev:

[Recommended]

[Sponsored]

[By Firefox]

[Recommended theme]