This repository was archived by the owner on Apr 16, 2021. It is now read-only.
Use get for dict access#68
Merged
Merged
Conversation
Contributor
Author
|
@acmiyaguchi r? |
acmiyaguchi
approved these changes
Jul 16, 2019
Contributor
acmiyaguchi
left a comment
acmiyaguchi
left a comment
There was a problem hiding this comment.
This seems like it's doing the right thing. It's worth creating a test-case for the error that happened in production by providing a dataframe with a few null keyed histograms to get_hist_avg.
Contributor
Author
|
@acmiyaguchi any thoughts on the error circleci is throwing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the edge case that failed on 7/5 that caused the job to crap out thereafter.