This repository was archived by the owner on Mar 15, 2022. It is now read-only.
GeckoWebExecutor implementation#27
Merged
andrenatal merged 5 commits intomozilla:masterfrom Feb 28, 2020
Merged
Conversation
arybin
reviewed
Feb 19, 2020
andrenatal
suggested changes
Feb 20, 2020
Contributor
andrenatal
left a comment
andrenatal
left a comment
There was a problem hiding this comment.
We need to understand why GeckoWebExecutor is not reading the response from the server properly.
keianhzo
force-pushed
the
geckoexecutor
branch
from
86b4a95 to
79dd211
Compare
keianhzo
force-pushed
the
geckoexecutor
branch
from
79dd211 to
4636a22
Compare
Contributor
Author
|
@andrenatal I've fixed the issue, made some changes and updated to AndroidX. I think this is ready for review, I've tested it in FxR and it works fine. You can test it in FxR using the |
Contributor
Author
|
@andrenatal You should be able to test this in FxR now: MozillaReality/FirefoxReality#2886 |
arybin
reviewed
Feb 27, 2020
| // called when response HTTP status is "200 OK" | ||
| String json = new String(response); | ||
| try { | ||
| JSONObject reader = new JSONObject(json); |
There was a problem hiding this comment.
it seems that this code is duplicated here and in GeckoNetworking.java consider extracting out into a helper class/or into parent class for parsing JSON into STTResult.
arybin
reviewed
Feb 27, 2020
| if (webResponse.body != null) { | ||
| ByteArrayOutputStream buffer = new ByteArrayOutputStream(); | ||
| int nRead; | ||
| byte[] data = new byte[16384]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@andrenatal This implementation adds support for a GeckoWebExecutor based Http connection so projects already using Gecko can simplify the Http stack. The problem is that I get an invalid answer from the server but I cannot debug it so I'm not sure what's happening or why the request is not valid.