Update rust according to moz-central updates [ci full]#4486
Merged
skhamis merged 4 commits intomozilla:mainfrom Sep 23, 2021
Merged
Update rust according to moz-central updates [ci full]#4486skhamis merged 4 commits intomozilla:mainfrom
skhamis merged 4 commits intomozilla:mainfrom
Conversation
mhammond
requested changes
Sep 21, 2021
Member
|
looks good to me in general, but flagging some nimbus folk |
Codecov Report
@@ Coverage Diff @@
## main #4486 +/- ##
==========================================
- Coverage 75.31% 75.30% -0.02%
==========================================
Files 47 47
Lines 4262 4260 -2
==========================================
- Hits 3210 3208 -2
Misses 1052 1052
Continue to review full report at Codecov.
|
skhamis
commented
Sep 21, 2021
|
|
||
| [toolchain] | ||
| channel = "1.52.1" | ||
| channel = "1.55.0" |
Contributor
Author
travis79
reviewed
Sep 22, 2021
Member
travis79
left a comment
There was a problem hiding this comment.
That's a lot of borrows being returned! I don't have any objection or concerns that can see, carry on!
9f5b558 to
935555b
Compare
mhammond
approved these changes
Sep 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4485,
According to our Rust policy we should be updating our toolchain to keep up with moz-central.
Note: Most of the changes came from running
cargo clippy --fixand some hand-changed but almost all of them are dealing the error:Pull Request checklist
[ci full]to the PR title.