Skip to content

Update rust according to moz-central updates [ci full]#4486

Merged
skhamis merged 4 commits intomozilla:mainfrom
skhamis:update-rust-1-55
Sep 23, 2021
Merged

Update rust according to moz-central updates [ci full]#4486
skhamis merged 4 commits intomozilla:mainfrom
skhamis:update-rust-1-55

Conversation

@skhamis
Copy link
Copy Markdown
Contributor

@skhamis skhamis commented Sep 21, 2021

fixes #4485,

According to our Rust policy we should be updating our toolchain to keep up with moz-central.

Note: Most of the changes came from running cargo clippy --fix and some hand-changed but almost all of them are dealing the error:

error: this expression borrows a reference that is immediately dereferenced by the compiler

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGES_UNRELEASED.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

@skhamis skhamis requested review from a team and mhammond September 21, 2021 00:46
Comment thread .circleci/config.yml
@mhammond
Copy link
Copy Markdown
Member

looks good to me in general, but flagging some nimbus folk

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 21, 2021

Codecov Report

Merging #4486 (935555b) into main (e178659) will decrease coverage by 0.01%.
The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4486      +/-   ##
==========================================
- Coverage   75.31%   75.30%   -0.02%     
==========================================
  Files          47       47              
  Lines        4262     4260       -2     
==========================================
- Hits         3210     3208       -2     
  Misses       1052     1052              
Impacted Files Coverage Δ
components/nimbus/examples/experiment.rs 0.00% <0.00%> (ø)
components/support/viaduct-reqwest/src/lib.rs 59.32% <0.00%> (ø)
components/viaduct/src/headers.rs 54.38% <ø> (ø)
components/nimbus/src/lib.rs 64.89% <15.00%> (ø)
components/nimbus/src/dbcache.rs 70.00% <100.00%> (ø)
components/nimbus/src/enrollment.rs 95.69% <100.00%> (-0.01%) ⬇️
components/nimbus/src/evaluator.rs 97.68% <100.00%> (ø)
components/nimbus/src/persistence.rs 94.20% <100.00%> (ø)
components/support/guid/src/lib.rs 87.14% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e178659...935555b. Read the comment docs.

@skhamis skhamis requested a review from mhammond September 21, 2021 02:03
@skhamis skhamis changed the title Update rust according to moz-central updates Update rust according to moz-central updates [ci full] Sep 21, 2021
Comment thread rust-toolchain

[toolchain]
channel = "1.52.1"
channel = "1.55.0"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that there is quite a few (mechanical) changes. @jhugman, @travis79 -- this is where the main rust version bump actually comes from

Copy link
Copy Markdown
Member

@travis79 travis79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a lot of borrows being returned! I don't have any objection or concerns that can see, carry on!

@skhamis skhamis merged commit 41575c3 into mozilla:main Sep 23, 2021
@skhamis skhamis deleted the update-rust-1-55 branch September 23, 2021 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to rust 1.55

4 participants