Skip to content

Add reporting of iOS logins migration metrics#4545

Merged
lougeniaC64 merged 1 commit intologins-per-field-encryptionfrom
logins-ios-metrics
Oct 12, 2021
Merged

Add reporting of iOS logins migration metrics#4545
lougeniaC64 merged 1 commit intologins-per-field-encryptionfrom
logins-ios-metrics

Conversation

@lougeniaC64
Copy link
Copy Markdown
Contributor

@lougeniaC64 lougeniaC64 commented Oct 8, 2021

Fixes #4473.

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGES_UNRELEASED.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #4545 (8977425) into logins-per-field-encryption (d80ee73) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                     Coverage Diff                      @@
##           logins-per-field-encryption    #4545   +/-   ##
============================================================
  Coverage                        78.81%   78.81%           
============================================================
  Files                               47       47           
  Lines                             4758     4758           
============================================================
  Hits                              3750     3750           
  Misses                            1008     1008           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d80ee73...8977425. Read the comment docs.

@lougeniaC64 lougeniaC64 force-pushed the logins-ios-metrics branch 7 times, most recently from 5d154a0 to 5f0fbea Compare October 8, 2021 22:19
@lougeniaC64 lougeniaC64 requested a review from skhamis October 8, 2021 22:43
@lougeniaC64 lougeniaC64 marked this pull request as ready for review October 8, 2021 22:44
@lougeniaC64 lougeniaC64 removed the request for review from skhamis October 9, 2021 01:20
@skhamis
Copy link
Copy Markdown
Contributor

skhamis commented Oct 12, 2021

This looks good to me! Thanks for adding tests for this!

Edit: Btw, the dependency test failings don't seem related to this PR

@lougeniaC64 lougeniaC64 merged commit 8456075 into logins-per-field-encryption Oct 12, 2021
@lougeniaC64 lougeniaC64 deleted the logins-ios-metrics branch October 12, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants