Add reporting of iOS logins migration metrics#4545
Merged
lougeniaC64 merged 1 commit intologins-per-field-encryptionfrom Oct 12, 2021
Merged
Add reporting of iOS logins migration metrics#4545lougeniaC64 merged 1 commit intologins-per-field-encryptionfrom
lougeniaC64 merged 1 commit intologins-per-field-encryptionfrom
Conversation
cea564f to
8977425
Compare
Codecov Report
@@ Coverage Diff @@
## logins-per-field-encryption #4545 +/- ##
============================================================
Coverage 78.81% 78.81%
============================================================
Files 47 47
Lines 4758 4758
============================================================
Hits 3750 3750
Misses 1008 1008 Continue to review full report at Codecov.
|
5d154a0 to
5f0fbea
Compare
5f0fbea to
a823f12
Compare
a823f12 to
64b017e
Compare
Contributor
|
This looks good to me! Thanks for adding tests for this! Edit: Btw, the dependency test failings don't seem related to this PR |
skhamis
approved these changes
Oct 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4473.
Pull Request checklist
[ci full]to the PR title.