Fix CI for building M1 simulator binaries

[skhamis]

Fixes #4585

Building swift packages locally works but not in CI. This was due to using debug instead of release -- reasons currently unknown and will be investigated and tracked in another task .

Pull Request checklist

• Quality: This PR builds and tests run cleanly
  • Note:
    • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
    • If this pull request includes a breaking change, consider cutting a new release after merging.
• Tests: This PR includes thorough tests or an explanation of why it does not
• Changelog: This PR includes a changelog entry in CHANGES_UNRELEASED.md or an explanation of why it does not need one
  • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
• Dependencies: This PR follows our dependency management guidelines
  • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

[codecov-commenter]

Codecov Report

Merging #4576 (02e5094) into main (2200912) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4576   +/-   ##
=======================================
  Coverage   80.69%   80.69%           
=======================================
  Files          48       48           
  Lines        5217     5217           
=======================================
  Hits         4210     4210           
  Misses       1007     1007           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2200912...02e5094. Read the comment docs.

[tarikeshaq]

Good catch!! 💯

[skhamis]

Hmmm, testing with the artifacts that came from this still produce the error on non-rosetta Xcode.....will need to do more testing!

[mhammond]

It's worth saying here something like: "We normally build debug versions if a git tag didn't trigger this job and release if one did, but for whatever reason .etc". And maybe open a new issue and add a reference to it here? That will just make it a bit more obvious why both branches are identical.

[skhamis]

It's worth saying here something like: "We normally build debug versions if a git tag didn't trigger this job and release if one did, but for whatever reason .etc". And maybe open a new issue and add a reference to it here? That will just make it a bit more obvious why both branches are identical.

After us talking about this a little more, we actually don't want to build debug in practice and if you end up needing symbols it's ideal to build that locally (it dramatically increases in size). I think keeping only release builds in CI make more sense. Thanks!