initial feature-manifest language setup#4588
Merged
tarikeshaq merged 3 commits intomainfrom Oct 19, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4588 +/- ##
==========================================
- Coverage 80.69% 80.63% -0.07%
==========================================
Files 48 51 +3
Lines 5217 5221 +4
==========================================
Hits 4210 4210
- Misses 1007 1011 +4
Continue to review full report at Codecov.
|
travis79
approved these changes
Oct 19, 2021
Member
travis79
left a comment
travis79
left a comment
There was a problem hiding this comment.
And thus Nimbus-FML was born :)
| .author("Nimbus SDK Engineering") | ||
| .about("A tool to generate code using an experiment feature manifest") | ||
| .arg( | ||
| Arg::with_name("manifest") |
Member
There was a problem hiding this comment.
Depending on how we go about it, we may have a need to enter multiple manifest files here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes https://mozilla-hub.atlassian.net/browse/SDK-400
Super minimal new crate setup, so others have something to start working off of, happy to move this elsewhere / take any feedback, but lets get this merged so we all have can work off the same crate, I'm not married to any type of project setup here, so feel free to change things up in future PRs!