Skip to content

remote_settings: Change the ConfigError message from ... to a helpful message.#6193

Merged
linabutler merged 1 commit intomainfrom
remote-settings-configerror-message
Apr 4, 2024
Merged

remote_settings: Change the ConfigError message from ... to a helpful message.#6193
linabutler merged 1 commit intomainfrom
remote-settings-configerror-message

Conversation

@linabutler
Copy link
Copy Markdown
Contributor

Oops! I caught this as soon as #6191 made it through the merge queue 🤦🏼‍♀️

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

@linabutler linabutler requested a review from bendk April 4, 2024 20:14
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 4, 2024

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 83.85%. Comparing base (0152f26) to head (f7109cf).
⚠️ Report is 1125 commits behind head on main.

Files with missing lines Patch % Lines
components/remote_settings/src/error.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6193   +/-   ##
=======================================
  Coverage   83.85%   83.85%           
=======================================
  Files         117      117           
  Lines       15671    15671           
=======================================
  Hits        13141    13141           
  Misses       2530     2530           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@linabutler linabutler enabled auto-merge April 4, 2024 20:33
@linabutler linabutler added this pull request to the merge queue Apr 4, 2024
Merged via the queue into main with commit 145160f Apr 4, 2024
@linabutler linabutler deleted the remote-settings-configerror-message branch April 4, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants