Skip to content

Conversation

@bendk
Copy link
Contributor

@bendk bendk commented Mar 21, 2025

Add a pub use statement to megazords/full/src/lib.rs for the new crate. Temisan ran into this when adding bindings for the merino client.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

@bendk bendk requested review from a team and skhamis March 21, 2025 19:26
Add a `pub use` statement to `megazords/full/src/lib.rs` for the new
crate.  Temisan ran into this when adding bindings for the `merino`
client.
@bendk bendk force-pushed the push-zzutmsqmkopk branch from 94b85be to 4d7ad84 Compare March 21, 2025 19:28
Copy link
Contributor

@skhamis skhamis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty for making that change, LGTM!

@bendk bendk added this pull request to the merge queue Mar 25, 2025
Merged via the queue into mozilla:main with commit 0e8ffbc Mar 25, 2025
15 checks passed
@bendk bendk deleted the push-zzutmsqmkopk branch March 25, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants