Skip to content

Conversation

@jo
Copy link
Contributor

@jo jo commented Mar 25, 2025

Android patch fixing recent test failures: https://phabricator.services.mozilla.com/D242808

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

Copy link
Contributor

@bendk bendk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just re-applying the changes we've already approved right? Seems fine to me.

@jo jo added this pull request to the merge queue Mar 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Mar 25, 2025
@dsmithpadilla
Copy link
Contributor

if possible , could we land this after the glean patch (1953191) lands in central? I'd like to make sure they land separately in case of any failures.

@bendk
Copy link
Contributor

bendk commented Mar 25, 2025

That sounds good. Jan-Erik and I are working through the Glean/UniFFI changes. Let's merge those today/tomorrow and this one after. Does that work for you @jo?

@jo jo force-pushed the revert-backouts branch from 1d871c5 to 3cf0c5a Compare March 26, 2025 12:31
@jo jo force-pushed the revert-backouts branch from 3cf0c5a to f1670e5 Compare March 26, 2025 21:12
@dsmithpadilla dsmithpadilla enabled auto-merge March 28, 2025 04:18
@dsmithpadilla dsmithpadilla added this pull request to the merge queue Mar 28, 2025
Merged via the queue into mozilla:main with commit 6455f5b Mar 28, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants