Skip to content

Make AmpMatchingStrategyArg discriminents start at 1#6683

Merged
bendk merged 1 commit into
mozilla:mainfrom
bendk:push-twvomkksprrn
Apr 2, 2025
Merged

Make AmpMatchingStrategyArg discriminents start at 1#6683
bendk merged 1 commit into
mozilla:mainfrom
bendk:push-twvomkksprrn

Conversation

@bendk
Copy link
Copy Markdown
Contributor

@bendk bendk commented Apr 2, 2025

This is the easiest way to land https://bugzilla.mozilla.org/show_bug.cgi?id=1924764.

The Desktop code for this currently assumes that discrimenents start at one. That's how it's worked historically, but that behavior was never correct. This allows us to fix the bug but not have to update the suggest desktop code.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

This is the easiest way to land https://bugzilla.mozilla.org/show_bug.cgi?id=1924764.

The Desktop code for this currently assumes that discrimenents start at
one.  That's how it's worked historically, but that behavior was never
correct.  This allows us to fix the bug but not have to update the
suggest desktop code.
@bendk bendk requested a review from 0c0w3 April 2, 2025 14:00
Copy link
Copy Markdown
Contributor

@0c0w3 0c0w3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bendk bendk added this pull request to the merge queue Apr 2, 2025
Merged via the queue into mozilla:main with commit 3703c02 Apr 2, 2025
@bendk bendk deleted the push-twvomkksprrn branch April 2, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants