Skip to content

Bug 1980474 - Add SearchEngineUrl::exclude_partner_code_from_telemetry to search config#6866

Merged
0c0w3 merged 1 commit intomainfrom
adw/search-exclude_partner_code_from_telemetry
Jul 31, 2025
Merged

Bug 1980474 - Add SearchEngineUrl::exclude_partner_code_from_telemetry to search config#6866
0c0w3 merged 1 commit intomainfrom
adw/search-exclude_partner_code_from_telemetry

Conversation

@0c0w3
Copy link
Contributor

@0c0w3 0c0w3 commented Jul 31, 2025

This is a speculative PR that adds SearchEngineUrl::exclude_partner_code_from_telemetry so that BrowserSearchTelemetry can know it should exclude the partner code for Google Lens from sap.counts. It's based on #6854.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@0c0w3 0c0w3 requested a review from Standard8 July 31, 2025 03:31
Copy link
Member

@Standard8 Standard8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a reasonable way of handling this. I can't think of anything better. We might need to have a specific partner_code field within the URL at some stage, but for now, I think this works and is flexible for future.

One thing I did notice, is that I think an entry needs adding in SearchEngineUrl::merge, as the value isn't being propagated up.

I think we'll probably need some tests as well.

@0c0w3 0c0w3 requested a review from Standard8 July 31, 2025 18:08
@0c0w3 0c0w3 changed the title Add SearchEngineUrl::exclude_partner_code_from_telemetry Bug 1980474 - Add SearchEngineUrl::exclude_partner_code_from_telemetry to search config Jul 31, 2025
Base automatically changed from adw/search-is-new-until-in-url-1979962 to main July 31, 2025 18:31
@0c0w3 0c0w3 force-pushed the adw/search-exclude_partner_code_from_telemetry branch from 12575ca to 4c3e97d Compare July 31, 2025 18:59
Copy link
Member

@Standard8 Standard8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates.

@0c0w3
Copy link
Contributor Author

0c0w3 commented Jul 31, 2025

Thanks, I'll squash these commits and merge.

@0c0w3 0c0w3 force-pushed the adw/search-exclude_partner_code_from_telemetry branch from 4c3e97d to 6b56dd4 Compare July 31, 2025 20:26
@0c0w3 0c0w3 enabled auto-merge July 31, 2025 20:55
@0c0w3 0c0w3 added this pull request to the merge queue Jul 31, 2025
Merged via the queue into main with commit 09ad5d6 Jul 31, 2025
15 checks passed
@0c0w3 0c0w3 deleted the adw/search-exclude_partner_code_from_telemetry branch July 31, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments