Conversation
Standard8
requested changes
Jul 31, 2025
Member
Standard8
left a comment
There was a problem hiding this comment.
I think this is a reasonable way of handling this. I can't think of anything better. We might need to have a specific partner_code field within the URL at some stage, but for now, I think this works and is flexible for future.
One thing I did notice, is that I think an entry needs adding in SearchEngineUrl::merge, as the value isn't being propagated up.
I think we'll probably need some tests as well.
SearchEngineUrl::exclude_partner_code_from_telemetrySearchEngineUrl::exclude_partner_code_from_telemetry to search config
12575ca to
4c3e97d
Compare
Contributor
Author
|
Thanks, I'll squash these commits and merge. |
…y to search config
4c3e97d to
6b56dd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a speculative PR that adds
SearchEngineUrl::exclude_partner_code_from_telemetryso thatBrowserSearchTelemetrycan know it should exclude the partner code for Google Lens fromsap.counts. It's based on #6854.Pull Request checklist
[ci full]to the PR title.