Skip to content

Conversation

@freshstrangemusic
Copy link
Member

Nimbus now exposes a test only recordEventSync method to use in tests becuase recordEvent dispatches the event recording to a background thread. Because the new JEXL parser is so fast, our EventStoreTests are now intermittently failing as the event recording hasn't finished by the time we actually evaluate the JEXL expressions. Using recordEventSync bypasses this issue entirely.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

Nimbus now exposes a test only `recordEventSync` method to use in tests
becuase `recordEvent` dispatches the event recording to a background
thread. Because the new JEXL parser is so fast, our EventStoreTests are
now intermittently failing as the event recording hasn't finished by the
time we actually evaluate the JEXL expressions. Using `recordEventSync`
bypasses this issue entirely.
@freshstrangemusic
Copy link
Member Author

We shouldn't merge this yet because there is a potential issue with this patch on iOS.

@mhammond
Copy link
Member

dep check could well be because upstream renamed their branch or something - regardless, I agree it's not this patch, and Jeff asked me to land it NOW :)

@mhammond mhammond added this pull request to the merge queue Aug 21, 2025
Merged via the queue into main with commit 4260ba7 Aug 21, 2025
59 of 60 checks passed
@mhammond mhammond deleted the push-nowzxlumqoly branch August 21, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants