Skip to content

Conversation

@Almaju
Copy link
Contributor

@Almaju Almaju commented Nov 4, 2025

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

Copy link
Contributor

@luc-lisi luc-lisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! Before we merge, can we update these with the changes from

#7048

Now that it is approved? Looks great though :)

@Almaju Almaju force-pushed the ads-client-integration-test branch from ee9ed5d to e136f0c Compare November 4, 2025 19:14
@Almaju Almaju enabled auto-merge November 4, 2025 19:15
@Almaju Almaju added this pull request to the merge queue Nov 4, 2025
Merged via the queue into mozilla:main with commit 2a83951 Nov 4, 2025
13 of 14 checks passed
@Almaju Almaju deleted the ads-client-integration-test branch November 4, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants