test(ads-client): Time dependent tests now use a fake clock #7059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luc-lisi
force-pushed
the
refactor-ads-client-with-mock-time
branch
4 times, most recently
from
5deb50d to
ef9c71b
Compare
luc-lisi
commented
Nov 5, 2025
| } | ||
| #[cfg(test)] | ||
| fn advance(&self, _secs: i64) { | ||
| panic!( |
Contributor
Author
There was a problem hiding this comment.
This looks funny. But maybe it's fine seeing as it's just test code? I couldn't find a super clean way to type this otherwise but maybe someone else has some ideas.
inline not needed cleanup wording fixed reorg
luc-lisi
force-pushed
the
refactor-ads-client-with-mock-time
branch
from
ef9c71b to
e25da93
Compare
Almaju
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had tests performing real timeouts to test caching behavior (specifically in regards to testing TTL logic). We have updated them to now have it be possible to build the cache with a "TestClock" which lets developers manually increment the system time.
This should speed up tests and also prevent non-deterministic behavior.
This does not affect production and we have included an extra local integration test that verifies this.
Pull Request checklist
[ci full]to the PR title.