-
Notifications
You must be signed in to change notification settings - Fork 254
feat(ads-client): handle different ad types #7073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a7aaf52 to
9b787b4
Compare
6e29755 to
05bbf78
Compare
d1ad0ae to
4ff3808
Compare
058bb97 to
74049d0
Compare
74049d0 to
669d6d8
Compare
luc-lisi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Thanks so much for this 🎉
You mentioned it in that other PR but I'd just make sure to rename these from ...UATile -> Tile to fit the new schema, but otherwise should be good to go 🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh actually, I realize we need to update the docs to include these new endpoints. I think we still have request_ads and are missing the one for tiles. But just a minor change and then it should be good to go!
request_image_ads()— returns single image ads per placementrequest_spoc_ads()— returns multiple spoc ads per placement (with count parameter)request_ua_tile_ads()— returns single UA tile ads per placementAd) to deserialize different ad types from JSON responsesMozAdsImage,MozAdsSpoc, andMozAdsUATilestructs for the public APIPull Request checklist
[ci full]to the PR title.