Skip to content

Conversation

@bendk
Copy link
Contributor

@bendk bendk commented Nov 14, 2025

This brings in mozilla/uniffi-rs#2733, which I'm hoping will reduce the crash frequency for
https://bugzilla.mozilla.org/show_bug.cgi?id=1992149. This is pretty speculative, but it seems worth a shot.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

This brings in mozilla/uniffi-rs#2733, which I'm
hoping will reduce the crash frequency for
https://bugzilla.mozilla.org/show_bug.cgi?id=1992149.  This is pretty
speculative, but it seems worth a shot.
Copy link
Contributor

@rvandermeulen rvandermeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are green and Mark reviewed the UniFFI change already in the upstream repo. Let's get this landed and into Nightly builds ASAP.

@rvandermeulen rvandermeulen added this pull request to the merge queue Nov 14, 2025
Merged via the queue into mozilla:main with commit d4753ab Nov 14, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants