Skip to content

Comments

Bug:2009480: [ci full] Evaluate jexl with returned results as json#7156

Merged
yashikakhurana merged 1 commit intomainfrom
bug_2009480
Jan 13, 2026
Merged

Bug:2009480: [ci full] Evaluate jexl with returned results as json#7156
yashikakhurana merged 1 commit intomainfrom
bug_2009480

Conversation

@yashikakhurana
Copy link
Contributor

@yashikakhurana yashikakhurana commented Jan 12, 2026

Add eval_jexl_detailed() method to NimbusTargetingHelper for CLI testing and debugging. Evaluates JEXL expressions and returns detailed results as JSON.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

ios pr- mozilla-mobile/firefox-ios#31607

@yashikakhurana yashikakhurana force-pushed the bug_2009480 branch 5 times, most recently from 07ff660 to 23cd80c Compare January 12, 2026 19:33
@yashikakhurana yashikakhurana marked this pull request as draft January 12, 2026 19:52
@yashikakhurana yashikakhurana changed the title Bug:2009480: Evaluate jexl with returned results as json Bug:2009480: [ci full] Evaluate jexl with returned results as json Jan 12, 2026
@yashikakhurana yashikakhurana marked this pull request as ready for review January 12, 2026 20:11
- Added eval_jexl_detailed() method to NimbusTargetingHelper interface in UDL
- Implemented method in Rust to evaluate JEXL expressions and return detailed JSON results
- Returns {"success": true, "result": <value>} on success or {"success": false, "error": "..."} on error
- Added Android Kotlin implementations in NimbusHelpers.kt
- Created 5 comprehensive tests with common helper function
- Updated CHANGELOG.md with breaking change warning

This is a breaking change that requires consumers to implement the new interface method.

iOS implementation: mozilla-mobile/firefox-ios#31607
@yashikakhurana yashikakhurana added this pull request to the merge queue Jan 13, 2026
Merged via the queue into main with commit c8feeaa Jan 13, 2026
59 checks passed
@yashikakhurana yashikakhurana deleted the bug_2009480 branch January 13, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants