Bug 2009482: Remove logcat filter in eval-jexl to support NimbusTooling tag#7173
Merged
yashikakhurana merged 5 commits intomainfrom Jan 21, 2026
Merged
Bug 2009482: Remove logcat filter in eval-jexl to support NimbusTooling tag#7173yashikakhurana merged 5 commits intomainfrom
yashikakhurana merged 5 commits intomainfrom
Conversation
This commit fixes two issues with the eval-jexl CLI: 1. Removed logcat filter (-s flag) to support both old builds that use 'NimbusTooling' log tag and new builds that use 'NimbusCLI' tag. 2. Clear logcat before sending the eval-jexl intent to prevent reading old/stale results from previous runs. 3. Increased retry timing from 2 seconds to 3 seconds and max retries from 2 to 3 attempts to give the app enough time to start and log the result (total wait time: up to 9 seconds). These changes make the CLI backward compatible and more reliable when evaluating JEXL expressions on Android devices.
Contributor
Author
|
freshstrangemusic
approved these changes
Jan 21, 2026
| prompt(&mut stdout, "# Waiting for result...")?; | ||
|
|
||
| let max_retries = 2; | ||
| let max_retries = 3; |
Member
There was a problem hiding this comment.
this should be a const MAX_RETRIES: u32 = 3; since its actually a constant.
|
|
||
| // Clear logcat before starting to ensure we only read fresh logs | ||
| if matches!(self, Self::Android { .. }) { | ||
| let _ = self.exe()?.args(["logcat", "-c"]).output(); |
Member
There was a problem hiding this comment.
If this returns an Error we should still propagate it.
Suggested change
| let _ = self.exe()?.args(["logcat", "-c"]).output(); | |
| self.exe()?.args(["logcat", "-c"]).output()?; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The eval-jexl feature logs results with the NimbusTooling tag, but the CLI was filtering for NimbusCLI tag which prevented it from finding results.
This commit removes the logcat filter entirely to ensure the CLI can find JEXL results regardless of the log tag used. This makes the CLI backward compatible with both old builds (using NimbusTooling) and new builds (using NimbusCLI).
Pull Request checklist
[ci full]to the PR title.