Switch Android to new viaduct backend (second try)#7264
Merged
bendk merged 1 commit intomozilla:mainfrom Mar 11, 2026
Merged
Conversation
The first attempt failed due to UniFFI FFI errors. We believe that the experimental FFI we're testing should fix this by avoiding passing structs over the FFI via JNA. The plan is to merge this and monitor FFI errors, hopefully this time we don't get a blow up like last time.
moztcampbell
approved these changes
Mar 11, 2026
Collaborator
moztcampbell
left a comment
There was a problem hiding this comment.
Trying this again seems reasonable to me.
Contributor
Author
|
Thanks! Mark gave the plan a thumbs up yesterday, so I'm just going to go ahead and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first attempt failed due to UniFFI FFI errors. We believe that the experimental FFI we're testing should fix this by avoiding passing structs over the FFI via JNA.
The plan is to merge this and monitor FFI errors, hopefully this time we don't get a blow up like last time.
Pull Request checklist
[ci full]to the PR title.