Skip to content

Switch Android to new viaduct backend (second try)#7264

Merged
bendk merged 1 commit intomozilla:mainfrom
bendk:push-lyowqqzzults
Mar 11, 2026
Merged

Switch Android to new viaduct backend (second try)#7264
bendk merged 1 commit intomozilla:mainfrom
bendk:push-lyowqqzzults

Conversation

@bendk
Copy link
Contributor

@bendk bendk commented Mar 11, 2026

The first attempt failed due to UniFFI FFI errors. We believe that the experimental FFI we're testing should fix this by avoiding passing structs over the FFI via JNA.

The plan is to merge this and monitor FFI errors, hopefully this time we don't get a blow up like last time.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

The first attempt failed due to UniFFI FFI errors.  We believe that the
experimental FFI we're testing should fix this by avoiding passing
structs over the FFI via JNA.

The plan is to merge this and monitor FFI errors, hopefully this time we
don't get a blow up like last time.
@bendk bendk requested a review from mhammond March 11, 2026 15:36
Copy link
Collaborator

@moztcampbell moztcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying this again seems reasonable to me.

@bendk bendk added this pull request to the merge queue Mar 11, 2026
@bendk
Copy link
Contributor Author

bendk commented Mar 11, 2026

Thanks! Mark gave the plan a thumbs up yesterday, so I'm just going to go ahead and merge.

Merged via the queue into mozilla:main with commit 8218445 Mar 11, 2026
13 checks passed
@bendk bendk deleted the push-lyowqqzzults branch March 11, 2026 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants