Skip to content

[DISCO-3505] remove fakespot support for suggest#7277

Merged
tiftran merged 4 commits intomainfrom
fakespot-remove
Mar 27, 2026
Merged

[DISCO-3505] remove fakespot support for suggest#7277
tiftran merged 4 commits intomainfrom
fakespot-remove

Conversation

@tiftran
Copy link
Copy Markdown
Contributor

@tiftran tiftran commented Mar 18, 2026

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@tiftran tiftran requested review from bendk and removed request for bendk March 18, 2026 21:43
@tiftran tiftran requested review from 0c0w3 and bendk March 18, 2026 23:31
Copy link
Copy Markdown
Contributor

@0c0w3 0c0w3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tif

Copy link
Copy Markdown
Contributor

@bendk bendk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, it looks great to me.

Mdn = 6,
Weather = 7,
Fakespot = 8,
// Fakespot = 8,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I liked how you added "removed" in the other enum, how about having that here too?

@tiftran tiftran added this pull request to the merge queue Mar 27, 2026
Merged via the queue into main with commit d64ec13 Mar 27, 2026
13 checks passed
@tiftran tiftran deleted the fakespot-remove branch March 27, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants