Bug 2029668 [RS] - Remove orphan attachments from db after a record is updated (backport #7294)#7304
Merged
rvandermeulen merged 1 commit intorelease-v150from Apr 6, 2026
Conversation
5 tasks
Contributor
|
/taskcluster ci full |
rvandermeulen
approved these changes
Apr 6, 2026
Contributor
rvandermeulen
left a comment
There was a problem hiding this comment.
Approved for A-S 150.0.1
* fix: remove orphaned attachments when records update * fix: add test that fails with orphan cleanup * fix: lint (cherry picked from commit 7c67b3c)
b07962e to
f5ec32a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We got a user report that Firefox on iOS is taking a lot of space ( also confirmed this is happening on Android too ). We managed to narrow it down to the
quicksuggest-amp.sqldb in remote settings being 1GB+ in some cases. See Slack thread for more context.This happens because whenever we update a record's attachment or tombstone a record we never clean up the orphan attachments. This should happen for all collections. I am assuming this manifested itself in
quicksuggest-ampbecause we update it frequently.Pull Request checklist
[ci full]to the PR title.This is an automatic backport of pull request #7294 done by [Mergify](https://mergify.com).