Skip to content

Bug 2029668 [RS] - Remove orphan attachments from db after a record is updated (backport #7294)#7304

Merged
rvandermeulen merged 1 commit intorelease-v150from
mergify/bp/release-v150/pr-7294
Apr 6, 2026
Merged

Bug 2029668 [RS] - Remove orphan attachments from db after a record is updated (backport #7294)#7304
rvandermeulen merged 1 commit intorelease-v150from
mergify/bp/release-v150/pr-7294

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Apr 6, 2026

We got a user report that Firefox on iOS is taking a lot of space ( also confirmed this is happening on Android too ). We managed to narrow it down to the quicksuggest-amp.sql db in remote settings being 1GB+ in some cases. See Slack thread for more context.

This happens because whenever we update a record's attachment or tombstone a record we never clean up the orphan attachments. This should happen for all collections. I am assuming this manifested itself in quicksuggest-amp because we update it frequently.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

This is an automatic backport of pull request #7294 done by [Mergify](https://mergify.com).

@rvandermeulen
Copy link
Copy Markdown
Contributor

/taskcluster ci full

@rvandermeulen rvandermeulen enabled auto-merge (rebase) April 6, 2026 20:22
Copy link
Copy Markdown
Contributor

@rvandermeulen rvandermeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for A-S 150.0.1

@rvandermeulen rvandermeulen disabled auto-merge April 6, 2026 20:53
@rvandermeulen rvandermeulen enabled auto-merge (rebase) April 6, 2026 20:53
* fix: remove orphaned attachments when records update

* fix: add test that fails with orphan cleanup

* fix: lint

(cherry picked from commit 7c67b3c)
@rvandermeulen rvandermeulen force-pushed the mergify/bp/release-v150/pr-7294 branch from b07962e to f5ec32a Compare April 6, 2026 20:54
@rvandermeulen rvandermeulen merged commit 147ba02 into release-v150 Apr 6, 2026
13 checks passed
@rvandermeulen rvandermeulen deleted the mergify/bp/release-v150/pr-7294 branch April 6, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants