refactor(ads-client): housekeeping - sort fields/methods, add UniFFI defaults, split docs, add Client in HttpCache#7316
Merged
Almaju merged 1 commit intomozilla:mainfrom Apr 10, 2026
Conversation
d49b8e6 to
31bdf94
Compare
ddd764b to
94aadf8
Compare
Code reviewFound 1 issue:
🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
…actor, split docs - Sort struct fields and enum variants alphabetically throughout - Sort methods: constructors → pub (alpha) → private (alpha) - Add #[uniffi(default = None)] to optional FFI fields for better consumer ergonomics (iab_content, cache config fields, ttl_seconds) - Replace manual Default impl with #[derive(Default)] (clippy) - Merge CacheMode struct+enum into single CachePolicy enum with Duration ttl; rename send_with_options → send_with_policy - Simplify fetch_and_cache TTL resolution: min(caller_ttl, server_ttl) - Add Client to HttpCache with set_client() for transport abstraction - Use Duration::from_secs() consistently instead of Duration::new(n, 0) - Make each language doc (JS, Kotlin, Swift) a complete standalone guide
94aadf8 to
058816e
Compare
Contributor
Author
|
Thanks @copyrighthero |
copyrighthero
requested changes
Apr 10, 2026
copyrighthero
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
[ci full]to the PR title.