Skip to content

Bug 2032774 - rename internal 'nss' crate to 'nss-as'#7362

Merged
mhammond merged 1 commit into
mozilla:mainfrom
mhammond:push-uxkoovntqysp
May 13, 2026
Merged

Bug 2032774 - rename internal 'nss' crate to 'nss-as'#7362
mhammond merged 1 commit into
mozilla:mainfrom
mhammond:push-uxkoovntqysp

Conversation

@mhammond
Copy link
Copy Markdown
Member

Intent is to make space for an "official" nss crate.

Seems like this is tedious but should be safe.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

Intent is to make space for an "official" nss crate.
@mhammond mhammond requested review from bendk and jo May 12, 2026 05:16
@mhammond mhammond marked this pull request as ready for review May 12, 2026 05:17
@mhammond
Copy link
Copy Markdown
Member Author

See https://bugzilla.mozilla.org/show_bug.cgi?id=2032774 for more context. I don't think this is particularly risky, right?

Copy link
Copy Markdown
Contributor

@jo jo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see risks either.
We need to make sure the workspace members in m-c gets updated when we merge.

Copy link
Copy Markdown
Contributor

@bendk bendk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mhammond
Copy link
Copy Markdown
Member Author

We need to make sure the workspace members in m-c gets updated when we merge.

They are just paths, which aren't changing here.

@mhammond mhammond added this pull request to the merge queue May 13, 2026
Merged via the queue into mozilla:main with commit cff11ab May 13, 2026
15 checks passed
@mhammond mhammond deleted the push-uxkoovntqysp branch May 13, 2026 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants