Fix #92 - Expose authenticator details to calling application #93
Conversation
|
Sending I'm doing this after a U2F Register or U2F Authenticate call. I take this to mean in order to use the "Get Version" query, I need to implement the smart card protocol, which would be a substantial expansion of the FIDO U2F implementation here far beyond the intention of this library. Hopefully there's another mechanism available, though I have not yet heard back from Yubico on that. |
|
With the help of Yubico, I've made this work well on MacOS via already-readily-accessible (but unknown to me) structs. I just need to verify this branch works on all four platforms and then I can make a release from it. |
jcjones
force-pushed
the
92-authenticator_details
branch
2 times, most recently
from
d3cf83d to
9de1ac8
Compare
jcjones
force-pushed
the
92-authenticator_details
branch
from
9de1ac8 to
e1f0662
Compare
jcjones
changed the title
jcjones
force-pushed
the
92-authenticator_details
branch
from
d660591 to
639c4ba
Compare
jcjones
force-pushed
the
92-authenticator_details
branch
2 times, most recently
from
de5db92 to
7b3eb30
Compare
jcjones
force-pushed
the
92-authenticator_details
branch
from
7b3eb30 to
93282ba
Compare
kjacobs-moz
left a comment
kjacobs-moz
left a comment
There was a problem hiding this comment.
Just one comment/question on the macOS implementation, otherwise this looks right.
Major changes: * Move to Rust 2018 edition #125 * Remove dependency on boxfnonce #121 * Reworked error handling #130 * Added a higher-level AuthenticatorService that can use multiple backends #123 * Changed the C API to use the new AuthenticatorService #123 * Added a Status channel for backends #122 * Now obtaining HID report sizes from the descriptors #112 * Add authenticator USB and Firmware details to the C API #93
This patch sets groundwork for additional authenticator metadata that Firefox will ultimately want to surface as part of its UX. Not all platforms have full support, but those that don't return safe values.