Bug 1524670 firefox_nondesktop_exact_mau28#11
Merged
Conversation
Contributor
|
Does this cover Bug 1524670? |
Contributor
Author
Sure does. |
relud
approved these changes
Mar 7, 2019
Contributor
relud
left a comment
relud
left a comment
There was a problem hiding this comment.
lgtm if we change the name of the tier1 columns, everything else is optional
| SELECT | ||
| *, | ||
| DATE_DIFF(submission_date, date_last_seen, DAY) AS _inactive_days, | ||
| DATE_DIFF(submission_date, date_last_seen_in_tier1_country, DAY) AS _inactive_days_tier1 |
Contributor
There was a problem hiding this comment.
this is an excellent optimization that I want to add along with wau to the desktop table
jklukas
force-pushed
the
nondesktop_exact_mau28
branch
from
20e2a45 to
bd82ca5
Compare
Contributor
|
the CI failure is due to multiple test suites running at the same time and getting a naming collision, working on a fix |
relud
approved these changes
Mar 7, 2019
In analogy to the `firefox_desktop_exact_mau28` tables, these allow very simple SUM queries that minimize the chance that your results differ from the calculations used for 2019 goals.
jklukas
force-pushed
the
nondesktop_exact_mau28
branch
from
2d3ecc1 to
998e285
Compare
jklukas
changed the title
quiiver
pushed a commit
that referenced
this pull request
Jun 25, 2024
Update workspace attach location
quiiver
pushed a commit
that referenced
this pull request
Jun 25, 2024
Import etl-graph as subtree instead of git module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In analogy to the
firefox_desktop_exact_mau28tables,these allow very simple SUM queries that minimize the chance that your
results differ from the calculations used for 2019 goals.