Skip to content

Conversation

@kwindau
Copy link
Contributor

@kwindau kwindau commented Dec 3, 2025

Description

This PR adds metadata descriptions to the following views:

  • adjust.adjust_cohort
  • adjust.adjust_kpi_deliverables
  • firefox_desktop.enterprise_metrics_clients
  • firefox_desktop.fx_cert_error_unique_users_normalized_channel
  • firefox_desktop.fx_cert_error_unique_users_os
  • firefox_desktop.fx_health_ind_bookmarks_by_os
  • firefox_desktop.fx_health_ind_bookmarks_by_os_version
  • firefox_desktop.fx_health_ind_webcompat
  • firefox_desktop.snippets
  • firefox_desktop.tos_rollout_enrollments
  • firefox_desktop.urlbar_events_daily
  • firefox_desktop.urlbar_events_daily_engagement_by_position
  • firefox_desktop.urlbar_events_daily_engagement_by_product_result_type
  • firefox_desktop_background_defaultagent.default_agent_agg
  • internet_outages.global_outages

Reviewer, please follow this checklist

@dataops-ci-bot

This comment has been minimized.

@kwindau kwindau force-pushed the metadata-completeness branch from 163056f to 4ad48b1 Compare December 3, 2025 18:18
@dataops-ci-bot

This comment has been minimized.

@dataops-ci-bot

This comment has been minimized.

@dataops-ci-bot

This comment has been minimized.

@dataops-ci-bot

This comment has been minimized.

@kwindau kwindau marked this pull request as ready for review December 3, 2025 19:46
@dataops-ci-bot
Copy link

Integration report for "Merge branch 'main' into metadata-completeness"

sql.diff

Click to expand!
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/adjust/adjust_cohort/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/adjust/adjust_cohort/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/adjust/adjust_cohort/metadata.yaml	2025-12-03 19:48:54.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/adjust/adjust_cohort/metadata.yaml	2025-12-03 19:48:18.000000000 +0000
@@ -1,8 +1,10 @@
-friendly_name: Adjust Cohort
-description: |-
-  Please provide a description for the query
-owners: []
-labels: {}
+friendly_name: Cohort data from external source Adjust
+description: |
+  This table represents data downloaded from Adjust using the https://api.adjust.com/kpis/v1/{app token}/cohorts link.
+owners:
+- mhirose@mozilla.com
+labels:
+  owner1: mhirose
 workgroup_access:
 - role: roles/bigquery.dataViewer
   members:
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/adjust/adjust_kpi_deliverables/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/adjust/adjust_kpi_deliverables/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/adjust/adjust_kpi_deliverables/metadata.yaml	2025-12-03 19:48:54.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/adjust/adjust_kpi_deliverables/metadata.yaml	2025-12-03 19:48:18.000000000 +0000
@@ -1,8 +1,10 @@
-friendly_name: Adjust Kpi Deliverables
-description: |-
-  Please provide a description for the query
-owners: []
-labels: {}
+friendly_name: Deliverables data from external source Adjust
+description: |
+  This table represents data downloaded from Adjust link using https://api.adjust.com/kpis/v1/{app token}.
+owners:
+- mhirose@mozilla.com
+labels:
+  owner1: mhirose
 workgroup_access:
 - role: roles/bigquery.dataViewer
   members:
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/enterprise_metrics_clients/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/enterprise_metrics_clients/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/enterprise_metrics_clients/metadata.yaml	2025-12-03 19:48:55.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/enterprise_metrics_clients/metadata.yaml	2025-12-03 19:48:17.000000000 +0000
@@ -1,8 +1,12 @@
-friendly_name: Enterprise Metrics Clients
+friendly_name: Enterprise Metrics (clients)
 description: |-
-  Please provide a description for the query
-owners: []
-labels: {}
+  Enterprise Metrics (clients).
+owners:
+- pissac@mozilla.com
+- kik@mozilla.com
+labels:
+  owner1: pissac
+  owner2: kik
 workgroup_access:
 - role: roles/bigquery.dataViewer
   members:
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/fx_cert_error_unique_users_normalized_channel/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/fx_cert_error_unique_users_normalized_channel/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/fx_cert_error_unique_users_normalized_channel/metadata.yaml	2025-12-03 19:48:55.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/fx_cert_error_unique_users_normalized_channel/metadata.yaml	2025-12-03 19:48:17.000000000 +0000
@@ -1,6 +1,7 @@
-friendly_name: Fx Cert Error Unique Users Normalized Channel
+friendly_name: Firefox Certificate Errors by Channel
 description: |-
-  Please provide a description for the query
+  Each row represents the count of unique users experiencing
+  certificate errors by day and by channel.
 owners: []
 labels: {}
 workgroup_access:
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/fx_cert_error_unique_users_os/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/fx_cert_error_unique_users_os/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/fx_cert_error_unique_users_os/metadata.yaml	2025-12-03 19:48:55.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/fx_cert_error_unique_users_os/metadata.yaml	2025-12-03 19:48:17.000000000 +0000
@@ -1,8 +1,11 @@
-friendly_name: Fx Cert Error Unique Users Os
+friendly_name: Firefox Certificate Errors by OS
 description: |-
-  Please provide a description for the query
-owners: []
-labels: {}
+  Each record represents the # of unique clients experience certificate
+  errors by day and by operating system.
+owners:
+- kwindau@mozilla.com
+labels:
+  owner1: kwindau
 workgroup_access:
 - role: roles/bigquery.dataViewer
   members:
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/fx_health_ind_bookmarks_by_os/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/fx_health_ind_bookmarks_by_os/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/fx_health_ind_bookmarks_by_os/metadata.yaml	2025-12-03 19:48:55.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/fx_health_ind_bookmarks_by_os/metadata.yaml	2025-12-03 19:48:17.000000000 +0000
@@ -1,8 +1,11 @@
-friendly_name: Fx Health Ind Bookmarks By Os
+friendly_name: Firefox Health Indicators - Bookmarks By OS by DAU
 description: |-
-  Please provide a description for the query
-owners: []
-labels: {}
+  Bookmarks added & opened per daily active user by OS.
+  Note: Limited to release channel only & app version >= 84.
+owners:
+- kwindau@mozilla.com
+labels:
+  owner1: kwindau
 workgroup_access:
 - role: roles/bigquery.dataViewer
   members:
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/fx_health_ind_bookmarks_by_os_version/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/fx_health_ind_bookmarks_by_os_version/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/fx_health_ind_bookmarks_by_os_version/metadata.yaml	2025-12-03 19:48:55.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/fx_health_ind_bookmarks_by_os_version/metadata.yaml	2025-12-03 19:48:17.000000000 +0000
@@ -1,8 +1,10 @@
-friendly_name: Fx Health Ind Bookmarks By Os Version
+friendly_name: Firefox Health Indicator - Bookmarks By OS Version
 description: |-
-  Please provide a description for the query
-owners: []
-labels: {}
+  Bookmarks added and opened per DAU, broken out by OS, OS version, channel, and date.
+owners:
+- kwindau@mozilla.com
+labels:
+  owner1: kwindau
 workgroup_access:
 - role: roles/bigquery.dataViewer
   members:
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/fx_health_ind_webcompat/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/fx_health_ind_webcompat/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/fx_health_ind_webcompat/metadata.yaml	2025-12-03 19:48:55.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/fx_health_ind_webcompat/metadata.yaml	2025-12-03 19:48:17.000000000 +0000
@@ -1,8 +1,10 @@
-friendly_name: Fx Health Ind Webcompat
+friendly_name: ETP Disablement by Country and Date
 description: |-
-  Please provide a description for the query
-owners: []
-labels: {}
+  Aggregate table of count of unique users setting ETP disablement by day/country; used in Firefox Health Indicator dashboard
+owners:
+- kwindau@mozilla.com
+labels:
+  owner1: kwindau
 workgroup_access:
 - role: roles/bigquery.dataViewer
   members:
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/snippets/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/snippets/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/snippets/metadata.yaml	2025-12-03 19:48:55.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/snippets/metadata.yaml	2025-12-03 19:48:17.000000000 +0000
@@ -1,8 +1,10 @@
 friendly_name: Snippets
 description: |-
-  Please provide a description for the query
-owners: []
-labels: {}
+  Contains Snippets specific data extracted from messaging_system_v1
+owners:
+- kwindau@mozilla.com
+labels:
+  owner1: kwindau
 workgroup_access:
 - role: roles/bigquery.dataViewer
   members:
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/tos_rollout_enrollments/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/tos_rollout_enrollments/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/tos_rollout_enrollments/metadata.yaml	2025-12-03 19:48:55.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/tos_rollout_enrollments/metadata.yaml	2025-12-03 19:48:17.000000000 +0000
@@ -1,8 +1,10 @@
 friendly_name: Tos Rollout Enrollments
 description: |-
-  Please provide a description for the query
-owners: []
-labels: {}
+  A client-level dataset from clients enrolled in the desktop ToS scaled rollout experiments.
+owners:
+- dberry@mozilla.com
+labels:
+  owner1: dberry
 workgroup_access:
 - role: roles/bigquery.dataViewer
   members:
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/urlbar_events_daily/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/urlbar_events_daily/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/urlbar_events_daily/metadata.yaml	2025-12-03 19:48:55.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/urlbar_events_daily/metadata.yaml	2025-12-03 19:48:17.000000000 +0000
@@ -1,8 +1,13 @@
 friendly_name: Urlbar Events Daily
 description: |-
-  Please provide a description for the query
-owners: []
-labels: {}
+  Each row in this table represents a daily summary statistic of impressions
+  and clicks per product result type per a host of meaningful dimensions.
+owners:
+- tbrooks@mozilla.com
+- akommasani@mozilla.com
+labels:
+  owner1: tbrooks
+  owner2: akommasani
 workgroup_access:
 - role: roles/bigquery.dataViewer
   members:
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/urlbar_events_daily_engagement_by_position/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/urlbar_events_daily_engagement_by_position/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/urlbar_events_daily_engagement_by_position/metadata.yaml	2025-12-03 19:48:55.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/urlbar_events_daily_engagement_by_position/metadata.yaml	2025-12-03 19:48:17.000000000 +0000
@@ -1,8 +1,10 @@
-friendly_name: Urlbar Events Daily Engagement By Position
+friendly_name: Urlbar Events Daily Engagement by Position
 description: |-
-  Please provide a description for the query
-owners: []
-labels: {}
+  Each row in this table represents a daily summary statistic of clicks per ordinal position per a host of meaningful dimensions.
+owners:
+- tbrooks@mozilla.com
+labels:
+  owner1: tbrooks
 workgroup_access:
 - role: roles/bigquery.dataViewer
   members:
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/urlbar_events_daily_engagement_by_product_result_type/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/urlbar_events_daily_engagement_by_product_result_type/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/urlbar_events_daily_engagement_by_product_result_type/metadata.yaml	2025-12-03 19:48:55.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/urlbar_events_daily_engagement_by_product_result_type/metadata.yaml	2025-12-03 19:48:17.000000000 +0000
@@ -1,8 +1,12 @@
 friendly_name: Urlbar Events Daily Engagement By Product Result Type
 description: |-
-  Please provide a description for the query
-owners: []
-labels: {}
+  Data from the urlbar_events ping to compute daily urlbar metrics per client.
+  This table will be used to power experiments, as querying the raw ping tables causes
+  Jetstream runs to either time out or run considerably longer.
+owners:
+- ascholtz@mozilla.com
+labels:
+  owner1: ascholtz
 workgroup_access:
 - role: roles/bigquery.dataViewer
   members:
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop_background_defaultagent/default_agent_agg/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop_background_defaultagent/default_agent_agg/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop_background_defaultagent/default_agent_agg/metadata.yaml	2025-12-03 19:48:54.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop_background_defaultagent/default_agent_agg/metadata.yaml	2025-12-03 19:48:15.000000000 +0000
@@ -1,8 +1,11 @@
-friendly_name: Default Agent Agg
+friendly_name: Firefox Desktop Background Default Agent Derived
 description: |-
-  Please provide a description for the query
-owners: []
-labels: {}
+  Aggregate table for firefox desktop background default agent pings,
+  grouped by major version, release channel, default browser, etc.
+owners:
+- wichan@mozilla.com
+labels:
+  owner1: wichan
 workgroup_access:
 - role: roles/bigquery.dataViewer
   members:
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/internet_outages/global_outages/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/internet_outages/global_outages/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/internet_outages/global_outages/metadata.yaml	2025-12-03 19:48:54.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/internet_outages/global_outages/metadata.yaml	2025-12-03 19:48:15.000000000 +0000
@@ -1,8 +1,13 @@
 friendly_name: Global Outages
-description: |-
-  Please provide a description for the query
-owners: []
-labels: {}
+description: "This query creates a unified view of global internet outage metrics\
+  \ by combining two historical datasets,\nv1 and v2, and selecting the appropriate\
+  \ version based on date.\nIt ensures analysts can query a single table to track\
+  \ outage indicators\u2014such as timeouts,\nunreachable rates, DNS performance,\
+  \ and SSL errors\u2014across all regions and time periods."
+owners:
+- aplacitelli@mozilla.com
+labels:
+  owner1: aplacitelli
 workgroup_access:
 - role: roles/bigquery.dataViewer
   members:

Link to full diff

@kwindau kwindau requested a review from wwyc December 3, 2025 19:59
@kwindau kwindau added this pull request to the merge queue Dec 3, 2025
Merged via the queue into main with commit ff176ff Dec 3, 2025
22 checks passed
@kwindau kwindau deleted the metadata-completeness branch December 3, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants